On Tue, 5 Oct 2004, Dan Malek wrote: > No, send a whole patch that _does_ something. Let's see all of these > changes at once. By itself, this patch is useless and doesn't add any > features, it just wastes our time discussing it.
ok, not a problem. i'll submit it any way the powers that be prefer, i just wanted explicit instructions on how. give me a day and i'll have a full, working patch. that does something. >> 2) redeclares reserved chunks in structures to be in terms of a >> standard char array, rather than the hideous combination of uint, >> ushort, and so on. (a purely aesthetic fix, admittedly.) > > Just for information, most of the original data structures were all > machine generated with some minor manual touch ups. I certainly > wasn't going to type in all of that stuff and risk mistakes with offsets > and sizes. that's definitely understandable. it's just potentially confusing to have a structure's reserved chunks declared as some combination of uchar, ushort, uint and/or ulong, when it's obviously more comprehensible to make each reserved chunk a standard array of char whose size is obvious at a glance. just for fun, $ cd include/asm-ppc $ grep -i reserved *.h man. the standards for declaring reserved space are all over the map, including this one: mpc52xx.h: volatile u32 reserved[4]; /* MMAP_CTRL + 0x3c .. 0x48 */ mpc52xx.h: volatile u32 reserved1; /* INTR + 0x20 */ mpc52xx.h: volatile u32 reserved2; /* INTR + 0x34 */ ... now *that* kind of creeps me out. why is reserved space being declared as "volatile"? yeesh. i may not understand what's happening here but, IMHO, if something is declared as reserved, that should be an indication that *nobody* is using it. if it's being used for anything, then it shouldn't be labelled as "reserved"; it should have a name. to be both volatile and reserved just makes me queasy. but that's just me. rday
