On Tue, Feb 11, 2014 at 02:38:34PM +0100, Miroslav Lichvar wrote:
> This allows gcc to check format strings used in pr_* calls.

With this series applied, this patch triggers a new warning on one of
my test builds (at least I assume it was this patch).

cc1: warnings being treated as errors
/home/richard/git/linuxptp/clockadj.c: In function 'sysclk_set_leap':
/home/richard/git/linuxptp/clockadj.c:128: error: format not a string literal 
and no format arguments

The patch below would fix it.

Thanks,
Richard
---
diff --git a/clockadj.c b/clockadj.c
index e0e82f0..fbf9423 100644
--- a/clockadj.c
+++ b/clockadj.c
@@ -125,7 +125,7 @@ void sysclk_set_leap(int leap)
        if (clock_adjtime(clkid, &tx) < 0)
                pr_err("failed to set the clock status: %m");
        else if (m)
-               pr_notice(m);
+               pr_notice("%s", m);
        realtime_leap_bit = tx.status;
 }

------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to