On Fri, Feb 21, 2014 at 01:30:44PM +0100, [email protected] wrote:

> diff --git a/config.c b/config.c
> index cfe36b8..f081619 100644
> --- a/config.c
> +++ b/config.c
> @@ -125,6 +125,12 @@ static enum parser_result parse_pod_setting(const char 
> *option,
>                       return r;
>               pod->neighborPropDelayThresh = uval;
>  
> +     } else if (!strcmp(option, "min_neighbor_prop_delay")) {
> +             r = get_ranged_int(value, &val, -20000000, -1);
                                                ^^^^^^^^^
So I meant that the default should be -20ms, but the absolute lower
bound allowed in the config file should still be INT_MIN.

...

> diff --git a/gPTP.cfg b/gPTP.cfg
> index 249269e..6f09215 100644
> --- a/gPTP.cfg
> +++ b/gPTP.cfg
> @@ -23,6 +23,7 @@ syncReceiptTimeout  3
>  delayAsymmetry               0
>  fault_reset_interval 4
>  neighborPropDelayThresh      800
> +min_neighbor_prop_delay      -20000000

This is good, but ...

> diff --git a/ptp4l.c b/ptp4l.c
> index d5a3aab..c8e12e1 100644
> --- a/ptp4l.c
> +++ b/ptp4l.c
> @@ -17,6 +17,7 @@
>   * with this program; if not, write to the Free Software Foundation, Inc.,
>   * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>   */
> +#include <limits.h>
>  #include <signal.h>
>  #include <stdio.h>
>  #include <stdlib.h>
> @@ -90,6 +91,7 @@ static struct config cfg_settings = {
>               .freq_est_interval = 1,
>               /* Default to very a large neighborPropDelay threshold */
>               .neighborPropDelayThresh = 20000000,
> +             .min_neighbor_prop_delay = INT_MIN,

... this should be -20ms as well.

Sorry if I wasn't clear.

Thanks,
Richard

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Linuxptp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to