On Fri, Apr 11, 2014 at 12:25:52PM +0200, Jiri Benc wrote:
> In order to be able to convert to a generic address struct, separate source
> and destination address into separate fields.
>
> Signed-off-by: Jiri Benc <jb...@redhat.com>
> ---
> ether.h | 13 ++++++-------
> raw.c | 22 +++++++++++-----------
> 2 files changed, 17 insertions(+), 18 deletions(-)
>
> diff --git a/ether.h b/ether.h
> index 07d0f31dae26..89e22c879058 100644
> --- a/ether.h
> +++ b/ether.h
> @@ -26,25 +26,24 @@
> #define PTP_DST_MAC 0x01, 0x1B, 0x19, 0x00, 0x00, 0x00
> #define P2P_DST_MAC 0x01, 0x80, 0xC2, 0x00, 0x00, 0x0E
>
> -struct eth_addr {
> - uint8_t dst[MAC_LEN];
> - uint8_t src[MAC_LEN];
> -} __attribute__((packed));
> +typedef uint8_t eth_addr[MAC_LEN];
Nit: I don't like this typedef for the reasons explained in the kernel
CodingStyle.
Also, I did not really understand why this change is needed.
Thanks,
Richard
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
