On Thu, Nov 13, 2014 at 06:31:09PM +0100, Jiri Benc wrote: > I don't like that phc_close is not called anymore after this patch. > I understand that it's not easy to do but IMHO this points out that > this approach is not the best one.
You are right that it is nicer and cleaner to close what we open. But that is easy to do, too: The clock instance can keep the ID and close it as before. Then, each port must only remember if they opened their own ID, and if so, close it again at the end. I'll respin this series on top of you new_state fix and incorporate the other comments. > What about creating a reference counted structure holding clkid and > reference it from struct port? This seems even better to me than my > original patch splitting struct clock. I think ref counts are overkill here. Thanks, Richard ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ Linuxptp-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
