On Fri, Aug 28, 2015 at 08:22:38PM +0200, Richard Cochran wrote:
> Buggy or mis-configured masters can place bogus logMessageInterval values
> in their delay response messages. This patch places reasonable limits on
> the range of values that we will accept.
Both patches in the series look good to me. Just one question.
> + if (rsp->hdr.logMessageInterval < -10 ||
> + rsp->hdr.logMessageInterval > 22) {
> + pr_debug("port %hu: ignore bogus delay request interval 2^%d",
> + portnum(p), rsp->hdr.logMessageInterval);
> + return;
Would it make sense to make it a warning message so the user can see
it and maybe think about reporting it to the vendor? To not spam the
syslog there could be a rate limit.
--
Miroslav Lichvar
------------------------------------------------------------------------------
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
