Looks reasonable to me, besides the one comment. I think it would make reading the code a bit easier of the PHC index was a separate function.
Thanks, Jake > -----Original Message----- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Saturday, April 09, 2016 12:32 PM > To: linuxptp-devel@lists.sourceforge.net > Subject: [Linuxptp-devel] [PATCH RFC 0/7] Prepare for TC, Batch II > > This is the second (and last) series in preparation for a Transparent > Clock implementation. > > Patches 1-3 and 5 make minor changes in the clock interface. > > Patches 4 and 7 move blocks of clock initialization logic out of > ptp4l.c:main() and into clock.c:clock_create(). > > Patch 6 follows up on patch 2 and lets the caller of clock_create > specify the desired type of clock. Currently we have only OC and BC, > but later on, we will add TC support. > > Review and comments are welcome. > > Thanks, > Richard > > > Richard Cochran (7): > Move the clock type enumeration into the clock header. > clock: offer a method to get the type rather than the number of ports. > clock: offer a method to get the first port in the list. > Perform the time stamping mode check in the clock module. > config: count the interfaces as they are added. > clock: specify type at creation time. > Let the clock code figure the PHC index. > > clock.c | 81 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > -- > clock.h | 29 ++++++++++++++++++----- > config.c | 2 ++ > config.h | 1 + > port.c | 7 +----- > ptp4l.c | 64 +++----------------------------------------------- > tlv.h | 8 ------- > 7 files changed, 106 insertions(+), 86 deletions(-) > > -- > 2.1.4 > > > ------------------------------------------------------------------------------ > Find and fix application performance issues faster with Applications > Manager > Applications Manager provides deep performance insights into multiple tiers > of > your business applications. It resolves application problems quickly and > reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/ > gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532 > _______________________________________________ > Linuxptp-devel mailing list > Linuxptp-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxptp-devel ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/ gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532 _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
