Henry, This is patch is *almost* ready for merging...
This patch causes a build failure: gcc phc_ctl.o phc.o sk.o util.o clockadj.o sysoff.o print.o version.o -lm -lrt -o phc_ctl sk.o: In function `sk_set_priority': sk.c:(.text+0x26e): undefined reference to `config_get_int' sk.c:(.text+0x286): undefined reference to `config_get_int' collect2: error: ld returned 1 exit status <builtin>: recipe for target 'phc_ctl' failed make: *** [phc_ctl] Error 1 (This is easy to fix in the makefile.) The subject line should look like this: Subject: [PATCH] Introduce options to set DSCP values in PTP messages. Then, the description should be formatted as a paragraph, not all on one line like this: > In the last years there are several media streaming standards evolving that > are relying on PTP. These standards make requirements about the DSCP priority > of PTP messages. This patch introduces two new configuration options > 'tos_event' and 'tos_general' to address that issue and to be able to set the > DSCP priority separately for PTP event messages and PTP general messages. but rather like this: --- In the last years there are several media streaming standards evolving that are relying on PTP. These standards make requirements about the DSCP priority of PTP messages. This patch introduces two new configuration options 'tos_event' and 'tos_general' to address that issue and to be able to set the DSCP priority separately for PTP event messages and PTP general messages. --- > diff -rwbBu a/ptp4l.8 b/ptp4l.8 > --- a/ptp4l.8 2015-09-19 16:25:11.000000000 +0200 > +++ b/ptp4l.8 2016-07-07 13:04:30.601314267 +0200 > @@ -446,6 +446,20 @@ > Specifies the address of the UNIX domain socket for receiving local > management messages. The default is /var/run/ptp4l. > .TP > +.B tos_event > +Defines the Differentiated Services Codepoint (DSCP) to be used for PTP > +event messages. Must be a value between 0 and 63. There are several media > +streaming standards out there that require specific values for this option. > +For example 46 (EF PHB) in AES67 or 48 (CS6 PHB) in RAVENNA. The default > +is 0. > +.TP > +.B tos_general > +Defines the Differentiated Services Codepoint (DSCP) to be used for PTP > +general messages. Must be a value between 0 and 63. There are several media > +streaming standards out there that recommend specific values for this option. > +For example 34 (AF41 PHB) in AES67 or 46 (EF PHB) in RAVENNA. The default > +is 0. > +.TP The descriptions in the man page are good now, thanks. Please avoid adding trailing white space. > diff -rwbBu a/sk.c b/sk.c > --- a/sk.c 2015-09-19 16:25:11.000000000 +0200 > +++ b/sk.c 2016-07-07 13:15:24.933969306 +0200 > @@ -35,6 +35,7 @@ > #include "missing.h" > #include "print.h" > #include "sk.h" > +#include "config.h" Here, please keep the #include directives in alphabetical order. > 2. Actually that config options could be done on per port > basis. Currently we decided explicitly against this, since a device > in a streaming network should not be able to use different > priorities for pTP messages on different ports to avoid > misconfiguration. It would be dangerous, if in a streaming network > by some misconfiguration there is the possibility to suppress PTP > event messages by media streams, which finally could lead to media > drop outs. Of course, if you prefer a per port option we will > implement it that way. What about the following use case? Maybe someone wants to run ptp4l as a BC between a normal 1588 network and an audio network. Several of the other options are per-port in order to allow this kind of bridging. For example, you can have a BC with one port UDP/IPv4 and another port Layer-2. Or you can connect E2E and P2P networks together. I don't have a strong opinion, and I think the patch is ok as is. We can always change to a port option later on... Thanks, Richard ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
