Until now I've tested your patch on a two-port device only. But it works fine 
here, 
as one would expect. ;-)

There is one message I'm still not sure about, but may be you can explain it 
shortly.
If I get a port up (except it is already up if ptp4l starts), I get the 
following message:
ptp4l[294.884]: eth1: SO_SELECT_ERR_QUEUE: Protocol not available

After that the port changes correctly from fault-state to LISTENING and all 
seem to 
work fine.

Best regards
Henry

-----Ursprüngliche Nachricht-----
Von: Richard Cochran [mailto:[email protected]] 
Gesendet: Dienstag, 9. August 2016 13:21
An: Jesuiter, Henry (ALC NetworX GmbH) <[email protected]>
Cc: [email protected]
Betreff: Re: [PATCH RFC 7/7] clock: Monitor the link status using a RT netlink 
socket.

On Tue, Aug 09, 2016 at 08:45:44AM +0000, Jesuiter, Henry (ALC NetworX GmbH) 
wrote:
> After trying out your patches, I've only one thing to mention.
> Since you are using c->pollfd[0] for the netlink fd, the pollfd
> resize() should use 'sizeof(struct pollfd)' instead of '1' for this 
> descriptor. Otherwise, you will get some memory corruption.

Putting that bug aside, does this series otherwise do what you need?

Thanks for the careful review,

Richard

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. http://sdm.link/zohodev2dev
_______________________________________________
Linuxptp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to