On Mon, Oct 17, 2016 at 08:46:22PM +0000, Keller, Jacob E wrote:
> On Mon, 2016-10-17 at 16:33 +0200, Miroslav Lichvar wrote:
> > When there are multiple instances of ptp4l or phc2sys running on the
> > system, it's difficult to tell which message belongs to which
> > instance. The first patch adds new options to ptp4l and phc2sys which
> > can be used to specify a different prefix for each instance, so
> > different instances can use different prefixes. One issue is that
> > it's
> > not possible to set the prefix in ptp4l config to its default value
> > (empty string) and the setting can't be included in defaults.cfg.
> > 
> Is it possible to update configuration somehow to allow passing a
> variable as "empty" which will assign it to empty string, and then
> update your prefix code flow so that it correctly works and doesn't add
> a " " when the string is actually empty? Not sure how easy it would be
> to fix that or not.

I think that would be an easy fix.

Another possibility is to allow double-quotes around strings in the
config. If the first and last character of the string was ", they
would be removed. The default value for logging_prefix would simply be
"". If someone is already using quoted strings in userDescription,
productDescription or revisionData, they would have to have an extra
pair of quotes around them.

What do you think?

Miroslav Lichvar

Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
Linuxptp-devel mailing list

Reply via email to