On Thu, Jun 15, 2017 at 10:16:43AM -0600, Brian Olson wrote:
> Miroslav Lichvar suggested that I submit these changes to linuxptp-devel.
Can you please resubmit those as two separate emails (not as
attachments), adding a SOB line. See the file, README.org, under
"Submitting Patches".
> In file included from rtnl.c:21:
> /usr/include/linux/netlink.h:35: error: expected specifier-qualifier-list
> before ‘sa_family_t’
> rtnl.c: In function ‘rtnl_link_query’:
> rtnl.c:59: error: ‘struct sockaddr_nl’ has no member named ‘nl_family’
> rtnl.c: In function ‘rtnl_open’:
> rtnl.c:154: error: ‘struct sockaddr_nl’ has no member named ‘nl_family’
> rtnl.c:155: error: ‘struct sockaddr_nl’ has no member named ‘nl_groups’
> make: *** [rtnl.o] Error 1
I don't get this. We already include <sys/socket.h>
#include <asm/types.h>
#include <linux/netlink.h>
#include <linux/rtnetlink.h>
#include <net/if.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/socket.h>
here ----------- ^^^
It appears that your C library headers are broken. How can this be?
Aren't you using RH enterprise?
In non-broken C libraries and C language programming in general, the
order of include directives is freely changeable.
In any case, your patch should at least avoid including the same
header twice.
Thanks,
Richard
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
