On Mon, Jul 17, 2017 at 05:22:29PM +0300, Mykola Zhuravel wrote:
> + case TLV_PORT_PROPERTIES_NP:
> + ppnp = (struct port_properties_np *) mgt->data;
> + if (ppnp->port_state > PS_SLAVE) {
> + ppnp->port_state = 0;
> + }
> + fprintf(fp, "PORT_PROPERTIES_NP "
> + IFMT "portIdentity %s"
> + IFMT "portState %s"
> + IFMT "timestamping %hhu"
This patch is okay as far as it goes, but can't we have a human
readable string here?
> + IFMT "interface %s",
> + pid2str(&ppnp->portIdentity), ps_str[ppnp->port_state],
> + ppnp->timestamping, text2str(&ppnp->interface));
> + break;
Thanks,
Richard
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
