On Wed, Jul 19, 2017 at 06:40:35PM +0300, Mykola Zhuravel wrote:
> - support getting counters of port RX/TX messages
> - support set(clear) counters of port RX/TX messages

This patch adds too many thing at once.  It really should be a series,
step by step.

The naming is terrible.  "port_counters" says you are counting ports,
but you are really counting packets.

More importantly, you need to explain why this is needed.  I can't
think of any use case for these statistics.

Thanks,
Richard

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to