On 27/07/2017 05:02, Richard Cochran wrote:
On Wed, Jul 26, 2017 at 10:23:05AM +0200, Miroslav Lichvar wrote:
On Mon, Jul 24, 2017 at 06:38:19PM +0200, Richard Cochran wrote:
+ if ((c->tds.flags & UTC_OFF_VALID && c->tds.flags & TIME_TRACEABLE) ||
+ (c->tds.currentUtcOffset > c->utc_offset)) {
+ pr_info("updating UTC offset to %d", c->tds.currentUtcOffset);
+ c->utc_offset = c->tds.currentUtcOffset;
I'm wondering what will happen if a buggy/misconfigured master is
briefly running with an UTC offset larger than the current offset.
Will the slaves be stuck with the wrong offset?
Jup.
Should be that ">" operator replaced with "!="?
The original idea was that the hard coded offset will become obsolete,
but the new offset is always larger. If we see a larger offset, then
it is at least plausible.
In contrast, a decreasing offset is always suspicious, because Earth's
rotational is slowing down, not speeding up.
Miroslav comment was re a buggy / misconfigured master.
Which seems a valid point.
Perhaps a warning is if the offset goes backwards.
--
Regards
Phil Reid
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
