Tuesday, March 20, 2018 3:27 PM >No, use a time out just like we do in other places, please.
Ok, great. I did not notice this. Much better than counter. I will include this, see summary in the end. >> msg: Added missing network to host convertion of for portIdentity in >> received delay response messages. >This should be a separate path. I guess you mean separate patch. If I put this in a separate patch I will build in a bug. If I put it before my patch with the queue, the legacy code won't work. If I put it after my patch with the queue, the queue patch won't work. Before queue patch: if (!pid_eq(&rsp->requestingPortIdentity, &req->hdr.sourcePortIdentity)) Rsp now in host order and req in network order After queue patch: if (!pid_eq(&rsp->requestingPortIdentity, &p->portIdentity)) Rsp still in network order and p in host order If all separate patches should work independently, I need to have msg fix in same patch as I include the queue, or include legacy fix for code I replace in queue patch. I find that unnecessary, better to include in same patch, or? >Please pay attention to the order of the patches. >This pruning needs to go in first, otherwise you have built a bug into the >previous patch! As I read it, you want me to include this in previous patch, since I cannot put it before previous since the queue does not exist there. If I summarize this, I will make two patches instead of three 1, port: Fix coding style (old 3/3) 2, port: Added TAILQ for sent delay_req (merge 1/3 and 2/3 + 5 sec limit in queue) Is this ok? /Anders ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
