> -----Original Message----- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Saturday, April 07, 2018 8:06 PM > To: linuxptp-devel@lists.sourceforge.net > Subject: [Linuxptp-devel] [PATCH RFC 0/8] Transparent Clock part II > > Here is second batch of background work needed for TC support. After > these are merged, then the actual TC code will be ready for posting... > > Patches 1-5 clean up the transport and message infrastructure. > Patch 6 expands the message functionality with a copy method. > Patches 7-8 extend the clock code to support virtual "syntonization". > > Richard Cochran (8): > transport: Use the proper enumerated event code. > transport: Fix callers to pass a proper enumeration value. > transport: Introduce transmit time stamp deferral. > transport: Introduce method for fetching a deferred transmit time > stamp. > msg: Refactor the finding of the TLV suffix on receive. > msg: Introduce a method to copy a message. > clock: Calculate frequency offset even without any delay estimation. > clock: Maintain the master/local rate ratio when free running. >
This all looked reasonable to me, but I do agree with Anders it should be made extra clear that the copy method takes a network order and returns a host byte order. Thanks, Jake > clock.c | 18 +++++++++++++++--- > msg.c | 47 +++++++++++++++++++++++++++++++++++++---------- > msg.h | 15 +++++++++++++++ > nsm.c | 2 +- > pmc_common.c | 3 ++- > port.c | 19 ++++++++++--------- > port.h | 6 +++--- > raw.c | 20 ++++++++++++++++---- > transport.c | 23 +++++++++++++++++------ > transport.h | 32 +++++++++++++++++++++++--------- > transport_private.h | 6 +++--- > udp.c | 22 +++++++++++++++++----- > udp6.c | 22 +++++++++++++++++----- > uds.c | 6 +++--- > 14 files changed, 179 insertions(+), 62 deletions(-) > > -- > 2.11.0 > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Linuxptp-devel mailing list > Linuxptp-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxptp-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
