Monday, May 28, 2018 4:16 PM > Sounds reasonable. This background information need to go into the > commit message so the reviewers know what the plan is.
I will update commit message > But temp storage belongs on the stack. I will fix with union and globals will be removed > You can also put the prototype into the mib.h file. I will add a general snmpd_mib.h with defines and init functions for the different mibs, and also prototype of run_pmc. mib.h couldn´t be used, already used in lib. > A union of all types might make sense. I will fix > I am not familiar with libsnmp, but if the mib2c tool generates useful > code, then we should use it directly. The code generation should take > place under the control of the makefile. The code is not complete, so it cant be generated and used directly. It only builds a skeleton and I only used it for the first object to get some hints. I will review the naming one more time to avoid camelCase. > Header file, please. I will fix ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
