On Wed, Jun 13, 2018 at 8:39 PM Richard Cochran <richardcoch...@gmail.com>
wrote:
> 1. normal - current code
> 2. check - read only ioctl; quit if setting not rich enough for the HW
time stamping mode
Yeah, I'd suggest naming these modes 'overwrite' and 'check'.
On Tue, Jun 12, 2018 at 12:40:06PM +0000, Geva, Erez wrote:
> +++ b/ptp4l.8
In the documentation, I suggest explaining that the reason this option is
needed is that the hardware timestamping setting on the network interface
is global - changing it affects the behavior of the interface for any
program on the system.
> + cfg.tx_type = tx_type;
> + if (ftm == HWTS_FILTER_IGNORE ||
> + cfg.rx_filter != HWTSTAMP_FILTER_ALL)
> + cfg.rx_filter = rx_filter;
I think the logic would be a lot simpler if you make this new readonly
option apply to both tx and rx. You'd either:
a) read the values, or
b) attempt to write the values
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
