Am 2018-09-03 13:58, schrieb Richard Cochran:
On Mon, Sep 03, 2018 at 01:44:19PM +0200, Michael Walle wrote:
Sending event messages to sockets which are already disconnected, eg.
a
client connecting over UDS, subscribing to an event and disconnects.
At the
moment, the subscriber is only removed when it times out because there
was
no recent TLV_SUBSCRIBE_EVENTS_NP.
This text is good to have in the changelog. ^^^
Ok.
> b) how this resolves it
>
>I wonder whether there might be a transient error, in which case it
>would make sense to keep the subscription.
Since UDS are reliable there shouldn't be transient errors, should it?
I'm not sure about that. I am concerned that that canceling might
break working clients.
According to the manual page they are "always reliable".
In
any case, if send() returns an ECONNREFUSED, the subscriber isn't
there
anymore and new events should not be delivered to it anymore.
So why not react to that specific error code?
IMHO it should be the other way around, there are more error codes
indicating serious errors and less which are transient (if there are
errors at all).
btw. reading the code again, shouldn't it be LIST_FOREACH_SAFE() in
clock_update_subscription()?
-michael
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
