Maybe I am missing something, but from what I can see from my demo, I can
set -S with this patch. Maybe there is something else I am not aware of?

I will also change the patch to also check clock_adjtime on device open

On Thu, Nov 8, 2018, 2:29 PM Richard Cochran <richardcoch...@gmail.com>
wrote:

> On Thu, Nov 08, 2018 at 02:09:09PM +0100, Dimitrios Katsaros wrote:
> > @@ -1053,6 +1052,14 @@ struct clock *clock_create(enum clock_type type,
> struct config *config,
> >                       return NULL;
> >               }
> >               clockadj_init(c->clkid);
> > +     } else if (phc_device) {
> > +             c->clkid = phc_open(phc_device);
> > +             if (c->clkid == CLOCK_INVALID) {
> > +                     pr_err("Failed to open %s: %m", phc);
> > +                     return NULL;
> > +             }
> > +             max_adj = clockadj_max_freq(c->clkid);
> > +             clockadj_init(c->clkid);
> >       } else {
> >               c->clkid = CLOCK_REALTIME;
> >               c->utc_timescale = 1;
>
> This patch looks good to me.  You have left the logic in place where
> SW time stamping selects CLOCK_REALTIME.  That is fine with me.
>
> But didn't you say that you needed SW time stamping with your non-PHC
> posix clock device?
>
> Thanks,
> Richard
>
>
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to