On Tue, Jun 23, 2020 at 12:27:27PM +0300, Vladimir Oltean wrote:
> Currently it is very finicky to deploy linuxptp in an automated build
> system and make KBUILD_OUTPUT pick up the output of "make
> headers_install" in order for the application to make full use of the
> features exposed by the runtime kernel. And the toolchain/libc will
> almost certainly never contain recent enough kernel headers to be of any
> use here. And there's no good reason for that: the application can probe
> at runtime for the sysoff methods supported by the kernel anyway.
> 
> So let's provide the kernel definitions for sysoff, sysoff_precise and
> sysoff_extended, such that SYSOFF_COMPILE_TIME_MISSING is not something
> that will bother us any longer.

I like the general idea, but this breaks when compiling against Linux
3.0 headers.  We support Linux 3.0 and newer, and we do, in fact, have
users still on that kernel!


In file included from /home/richard/git/linuxptp/phc.h:22,
                 from /home/richard/git/linuxptp/phc.c:29:
/home/richard/git/linuxptp/missing.h:112:31: error: ‘PTP_MAX_SAMPLES’ 
undeclared here (not in a function)
  struct ptp_clock_time ts[2 * PTP_MAX_SAMPLES + 1];
                               ^~~~~~~~~~~~~~~
make: *** [<builtin>: phc.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from /home/richard/git/linuxptp/rtnl.c:31:
/home/richard/git/linuxptp/missing.h:112:31: error: ‘PTP_MAX_SAMPLES’ 
undeclared here (not in a function)
  struct ptp_clock_time ts[2 * PTP_MAX_SAMPLES + 1];
                               ^~~~~~~~~~~~~~~

and so on ...


_______________________________________________
Linuxptp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to