Changed in V2 ~~~~~~~~~~~~~ - Picked up review tags from Jacob and Vladimir. - Implemented changes from Vladimir's review.
Looking into the PMC agent code, there are issues that will need resolution. This series converts the subscribe and update methods into the canonical form. The first patch prepares the way for implementing consistent return value semantics. The second patch renames the subscribe method, which is a straightforward conversion. The remaining five patches deal with the update method. Even with the simplifications, still the end result seems suspicious, because when writing the documentation, it is hard to put purpose of this method into words. This method calls into run_pmc, as do most of the remaining methods to be converted, and that function is fairly complex. It remains to be seen whether it can be disentangled into a more coherent form. Richard Cochran (7): Introduce error codes for the run_pmc method. pmc_agent: Convert the subscribe method into the canonical form. pmc_agent: Simplify the update method. pmc_agent: Simplify logic in update method. pmc_agent: Remove bogus comparison between last update and now. pmc_agent: Perform time comparison using positive logic. pmc_agent: Rename the update method and attempt to document it. phc2sys.c | 10 +++-- pmc_agent.c | 122 ++++++++++++++++++++++++++++++++-------------------- pmc_agent.h | 30 ++++++++++++- 3 files changed, 110 insertions(+), 52 deletions(-) -- 2.20.1 _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
