Hello,
there are small typos in scaled_ns_n2h and scaled_ns_h2n, *_msb instead
of *_lsb. Please see attached patch.

j
From f36f8836ed4fcb254d7470ae05797a2979a39939 Mon Sep 17 00:00:00 2001
From: Juergen Werner <pogoj...@gmx.net>
Date: Mon, 25 Jan 2021 18:03:09 +0100
Subject: [PATCH] tlv: Fix byte reordering in ScaledNs

A typo caused the loss of the information in field "nanoseconds_lsb" in
ScaledNs struct during pre_send and post_recv.

Signed-off-by: Juergen Werner <pogoj...@gmx.net>
---
 tlv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tlv.c b/tlv.c
index 738e404..879bb7e 100644
--- a/tlv.c
+++ b/tlv.c
@@ -42,14 +42,14 @@ static TAILQ_HEAD(tlv_pool, tlv_extra) tlv_pool =
 static void scaled_ns_n2h(ScaledNs *sns)
 {
 	sns->nanoseconds_msb = ntohs(sns->nanoseconds_msb);
-	sns->nanoseconds_lsb = net2host64(sns->nanoseconds_msb);
+	sns->nanoseconds_lsb = net2host64(sns->nanoseconds_lsb);
 	sns->fractional_nanoseconds = ntohs(sns->fractional_nanoseconds);
 }

 static void scaled_ns_h2n(ScaledNs *sns)
 {
 	sns->nanoseconds_msb = htons(sns->nanoseconds_msb);
-	sns->nanoseconds_lsb = host2net64(sns->nanoseconds_msb);
+	sns->nanoseconds_lsb = host2net64(sns->nanoseconds_lsb);
 	sns->fractional_nanoseconds = htons(sns->fractional_nanoseconds);
 }

--
2.30.0

_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to