Yes that's rite. There is no such field called clockClassThreshold while we 
have clockClass field
specified in 1588v2 spec. The naming convention from clockClassThreshold to 
clock_class_threshold
was changed as part of addressing review comments.

Thanks,
Ramana 

-----Original Message-----
From: Richard Cochran [mailto:richardcoch...@gmail.com] 
Sent: 17 February 2021 09:51
To: Jacob Keller
Cc: linuxptp-devel@lists.sourceforge.net
Subject: Re: [Linuxptp-devel] [PATCH 2/2] Clock Class Threshold Feature 
addition for PTP4L

CAUTION: This email originated from outside of Altiostar. Do not click on links 
or open attachments unless you recognize the sender and you are sure the 
content is safe. You will never be asked to reset your Altiostar password via 
email.


On Tue, Feb 16, 2021 at 02:08:44PM -0800, Jacob Keller wrote:
> On 2/14/2021 9:59 PM, Karthikkumar V wrote:
> > -   c->clock_class_threshold = config_get_int(config, NULL, 
> > "clockClassThreshold");
> > +   c->clock_class_threshold = config_get_int(config, NULL, 
> > "clock_class_threshold");
> >
>
>
> Why this change? It seems weird to remove this variable and introduce
> another? clockClassThreshold is supposed to be the standard isn't it?

I think Karthikkumar made a delta patch to the previous one.

(and no, there is no clockClassThreshold in 1588)

Thanks,
Richard


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to