On Sun, May 23, 2021 at 06:40:58AM -0700, Richard Cochran wrote:
> On Sat, May 22, 2021 at 05:09:07PM +0300, Amar Subramanyam via Linuxptp-devel 
> wrote:
> > @@ -1983,7 +1982,9 @@ static void handle_state_decision_event(struct clock 
> > *c)
> >                     event = EV_RS_PASSIVE;
> >                     break;
> >             case PS_SLAVE:
> > -                   clock_update_slave(c);
> > +                   if (fresh_best) {
> > +                           clock_update_slave(c);
> > +                   }
> 
> This is not correct.  Elements of the upstream data sets might have
> changed, and the port needs to stay up to date.

Is there something else that is not already covered by the
clock_update_time_properties() call from port.c?

-- 
Miroslav Lichvar



_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to