On Tue, May 25, 2021 at 08:35:35PM +0000, Keller, Jacob E wrote:
> > Reset the clock check to avoid false positives when switching between
> > slave and non-slave state and the clock is controlled by an external
> > process (e.g. phc2sys -rr).
> >
>
>
> The way this is worded, I expected clockcheck_reset to only be called if the
> clock is controlled by an external process, but we seem to call this every
> time.
Detecting that would be difficult and unreliable. I'll reword the
message to me it more clear.
> > if (!cid_eq(&best_id, &c->best_id) || best != c->best) {
> > clock_freq_est_reset(c);
> > + clockcheck_reset(c->sanity_check);
And here is a missing check for NULL in case it is disabled.
Thanks,
--
Miroslav Lichvar
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
