On Sat, Jul 03, 2021 at 03:59:24AM +0000, Eric Decker wrote:
> Subject: [PATCH] Always send with a unique sequence count from uds. Only 
> forward responses to UDS port with corresponding requests on the UDS port.

Please format the commit with:

1. A brief, one sentence subject line.

2. A commit message of that provides three pieces of information:

   1. The context of the issue/feature.
   2. The problem that needs fixing (or missing feature).
   3. How the proposed solution fixes the problem.

   (This means that the commit message is at least three complete English 
sentences)

> @@ -1404,17 +1405,83 @@ static void clock_forward_mgmt_msg(struct clock *c, 
> struct port *p, struct ptp_m  {
>       struct port *piter;
>       int pdulen = 0, msg_ready = 0;
> +     static UInteger16 mgmt_seq_count = 0;
> +     UInteger16 temp_seq_count = 0;
>  
> +     struct uds_mgmt_req {
> +             UInteger16 seqId;
> +             Enumeration16 id;
> +     };
> +     #define MGMT_REQ_Q_SIZE 4
> +     static struct uds_mgmt_req uds_req[MGMT_REQ_Q_SIZE] = {0};
> +     static unsigned int uds_req_index = 0;
> +     int forward_to_uds = 0;
> +     struct management_tlv *mgt = (struct management_tlv *) 
> +msg->management.suffix;

Your mailer mangled that line ^^^

> +     
>       if (forwarding(c, p) && msg->management.boundaryHops) {
>               pdulen = msg->header.messageLength;
>               msg->management.boundaryHops--;
> +
> +             if (p == c->uds_rw_port)
> +             {

Please follow CODING_STYLE.org

Thanks,
Richard


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to