> -----Original Message-----
> From: Keller, Jacob E
> Sent: Monday, November 22, 2021 5:23 PM
> To: Vladimir Oltean <olte...@gmail.com>; richardcoch...@gmail.com
> Cc: linuxptp-devel@lists.sourceforge.net
> Subject: RE: [Linuxptp-devel] [PATCH 2/2] util: fix dangling file descriptors
> on the
> error path of posix_clock_open
>
>
>
> > -----Original Message-----
> > From: Vladimir Oltean <olte...@gmail.com>
> > Sent: Monday, November 22, 2021 4:38 PM
> > To: richardcoch...@gmail.com
> > Cc: linuxptp-devel@lists.sourceforge.net
> > Subject: [Linuxptp-devel] [PATCH 2/2] util: fix dangling file descriptors
> > on the
> > error path of posix_clock_open
> >
> > When we determine that the "device" argument represents a path to a char
> > device, we call phc_open() and then we attempt to see, if the device
> > real path starts with "/dev/ptp", what number comes afterwards. If that
> > fails, we should close the char device we've just opened.
> >
> > Fixes: 380d023abb1f ("posix_clock_open: derive PHC index from device name if
> > possible")
> > Signed-off-by: Vladimir Oltean <olte...@gmail.com>
>
>
> Does this really need to be a separate commit? It seems like we could have
> squashed this into the same fix as the series.
>
If you really want it to be separate, I suggest doing this one first in the
series.
Thanks,
Jake
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
