On 10/25/2021 12:25 AM, Miroslav Lichvar wrote: > On Fri, Oct 22, 2021 at 03:03:57PM -0700, Jacob Keller wrote: >> The current implementation of test_phc cmp has a fallback flow for comparing >> the PHC clock to the CLOCK_REAMTIME. This fallback flow calculates the >> inverse offset compared to the offsets calculated by the PTP_SYS_OFFSET >> ioctls. >> >> Fix this by replacing its implementation with the one from phc2sys. Move >> read_phc function into clockadj.c to re-use it. > > Looks good to me. > > I'd just expect a comment about the order of declarations in > clockadj_compare() that could be fixed as the code is being moved. >
Not sure I follow your suggestion here? Do you just mean the way the local variables in clockadj_compare are declared? Thanks, Jake _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
