On Tue, Mar 15, 2022 at 10:40:02PM +0000, Keller, Jacob E wrote:
> The ice hardware has a semaphore to protect accesses to the clock register. 
> Multiple functions might access the clock at the same time. The semaphore 
> prevents this. If we fail to acquire the semaphore in a short time, we give 
> up on the gettime function and exit with -EBUSY.
> 
> Does the inner call log a debug message? if not perhaps we might want to add 
> such a debug message to this as well?

Yes, there is a debug message for that:

phc2sys[497426.052]: ioctl PTP_SYS_OFFSET_EXTENDED: Device or resource busy
phc2sys[497434.057]: ioctl PTP_SYS_OFFSET_EXTENDED: Device or resource busy
phc2sys[497452.132]: ioctl PTP_SYS_OFFSET_EXTENDED: Device or resource busy

A potential issue is that if the ioctl happens to fail on the first
use in sysoff_probe(), phc2sys will fall back to a worse ioctl. We
could repeat the probe multiple times and use the best result, or
maybe specifically check for the known error numbers like -EBUSY, -EIO.

-- 
Miroslav Lichvar



_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to