On Tue, 22 Mar 2022 at 04:13, Richard Cochran <richardcoch...@gmail.com> wrote:
> On Mon, Mar 07, 2022 at 03:57:19PM +0100, Erez Geva wrote: > > Use proper management TLV name in print. > > Use a simple 16 unsigned bits format. > > Follow standard name for number of records in a table. > > > > Signed-off-by: Erez Geva <erez.geva....@siemens.com> > > --- > > pmc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/pmc.c b/pmc.c > > index 7916153..ab36856 100644 > > --- a/pmc.c > > +++ b/pmc.c > > @@ -545,8 +545,8 @@ static void pmc_show(struct ptp_message *msg, FILE > *fp) > > break; > > case MID_UNICAST_MASTER_TABLE_NP: > > umtn = (struct unicast_master_table_np *) mgt->data; > > - fprintf(fp, "MID_UNICAST_MASTER_TABLE_NP " > > - IFMT "actual_table_size %" PRIu16, > > + fprintf(fp, "UNICAST_MASTER_TABLE_NP " > > Dropping MID_ prefix = good catch > > > + IFMT "actualTableSize %hu", > As actualTableSize name comes from the IEEE standard. I follow the standard name. The variable name in the structure is internal, so it can follow the Linux code style. > but fields of unicast_master_table_np are all lower case following our > Codingstyle (custom stuff avoids camelCase) > > > umtn->actual_table_size); > > See? ----------------------- ^^^^^^^^^^^^^^^^^^ > > Thanks, > Richard > > Erez > > _______________________________________________ > Linuxptp-devel mailing list > Linuxptp-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxptp-devel >
_______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
