> -----Original Message-----
> From: Miroslav Lichvar <mlich...@redhat.com>
> Sent: Monday, March 28, 2022 11:28 PM
> To: Keller, Jacob E <jacob.e.kel...@intel.com>
> Cc: linuxptp-devel@lists.sourceforge.net
> Subject: Re: [Linuxptp-devel] [PATCHv2 2/4] sysoff: Change sysoff_measure() to
> return ioctl errno.
>
> On Fri, Mar 25, 2022 at 12:24:47AM +0000, Keller, Jacob E wrote:
> > > -----Original Message-----
> > > From: Miroslav Lichvar <mlich...@redhat.com>
> > > Sent: Thursday, March 24, 2022 6:20 AM
> > > To: linuxptp-devel@lists.sourceforge.net
> > > Subject: [Linuxptp-devel] [PATCHv2 2/4] sysoff: Change sysoff_measure() to
> > > return ioctl errno.
> > >
> > > Return -errno instead of SYSOFF_RUN_TIME_MISSING from the sysoff
> > > measurement functions to allow the callers to check for specific errors.
> > >
> >
> > This is changing from returning the type to returning an error code. I would
> have expected equivalent changes to the other applications that use this..
>
> SYSOFF_RUN_TIME_MISSING has a negative value. The existing callers of
> sysoff_measure() already check for "< 0" or ">= 0". It should work
> as it is.
>
> --
> Miroslav Lichvar
Ok sure. And we never cared which specific type was used so that seems ok too.
Thanks,
Jake
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
