On Thu, Apr 07, 2022 at 05:47:47PM +0800, Hangbin Liu wrote:
> Sorry for my bad English.

No need to apologize!  I appreciate your contributions, but I just
want the code to super clean and clear...

> I adjust the code, not sure if this time it would be
> clear.
> 
> STAILQ_FOREACH(iface, &config->interfaces, list) {
>       interface_get_tsinfo(iface);
>       if (interface_tsinfo_valid(iface) &&
>           interface_tsmodes_supported(iface, required_modes))
>               continue;
> 
>       /* Get iface and check ts_info failed, let's see if there is
>        * a useable ts_label and try get_tsinfo again */

Can you refactor this somehow so that get_tsinfo doesn't need to be
called twice?

Thanks,
Richard


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to