Hi Richard, Thanks for your response. We have reviewed the patch again as per your suggestion.
1. We have invested time in development and have been verified by the team as a complete solution which is addressing the requirements of G.8275.2 Breaking the changes into small patches may lead to intermediate functionality breaks. So we strongly feel this should be taken as a single patch which addresses the complete G.8275.2 requirements. 2. GPL2.0 License mandates that If the software is modified by someone then recipients should know that what they have is not the original so that any problems introduced by others will not reflect on the original authors' reputations. *"Also, for each author's protection and ours, we want to make certain that everyone understands that there is no warranty for this free software. If the software is modified by someone else and passed on, we want its recipients to know that what they have is not the original, so that any problems introduced by others will not reflect on the original authors' reputations."* That's why we have added, "> + * @note Copyright (C) 2022 SyncMonk Technologies <servi...@syncmonk.net>" in all the files modified by SyncMonk Technologies. And we recommend that this practice should be adopted by community members. Thanks, Devasish Dey Vice President Engineering Product Development | SyncMonk Technologies Pvt Limited +91-783-8079202 devasish....@syncmonk.net www.syncmonk.net 367, KPC Layout, Bangalore-560035 On Mon, 16 May 2022 at 19:55, Richard Cochran <richardcoch...@gmail.com> wrote: > On Mon, May 16, 2022 at 02:08:06PM +0530, SyncMonk Technologies wrote: > > From: SyncMonk <servi...@syncmonk.net> > > > > 1. Inclusion of virtual PTP port on a PTP clock. (G.8275 Annex B) > > 2. Alternate master support (G.8275.2 Section 6.9 and G.8275.2 Appendix > III) > > 3. TLV support for interface rate (G.8275.2 Annex D) > > When master and slave instance interacting with each other operating > > at different interface speed, delay assymetry needs to be compensated > > as described in G.8271 appendix V. > > 4. Delay mechanism > > As per IEEE1588-2019, Table 21 adding NO_MECHANISM support. In this > > case port does not implement the delay mechanism. > > 5. Packet Timing Signal Fail (PTSF)(G.8275.2 Section 6.7.11) > > - PTSF-lossSync > > signal raised due to lack of reception of PTP Sycn, Followup or > > delay response messages > > - PTSF-unusable > > unusable PTP packet timing signal received by the request-port, > > exceeding the input tolerance of the request-port > > 6. Dynamic data set updates for external servo. > > - defaultDS.clockQuality.clockClass > > To support holdover in the T-BC-P/A and T-GM. > > - timePropertiesDS.frequencyTraceable > > To support availability of a PRC-traceable physical layer > > frequency input signal > > - PTSF Unusable. > > > Wow, that is a massive set of changes. > > > 38 files changed, 1530 insertions(+), 54 deletions(-) > > This is WAY too big for one commit. I need to see small, granular > changes. I guess your list of 6 new features would be 6 patch series > of 3-4 patches each. > > > @@ -15,6 +15,14 @@ > > * You should have received a copy of the GNU General Public License > along > > * with this program; if not, write to the Free Software Foundation, > Inc., > > * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > + * > > + * @note Copyright (C) 2022 SyncMonk Technologies < > servi...@syncmonk.net> > > + * Also, for each author's protection and ours, we want to make certain > that > > + * everyone understands that there is no warranty for this free > software. > > + * If the software is modified by someone else and passed on, we want > its > > + * recipients to know that what they have is not the original, so that > any > > + * problems introduced by others will not reflect on the original > authors' > > + * reputations. > > Please drop this extra legalese. > > Thanks, > Richard > > > _______________________________________________ > Linuxptp-devel mailing list > Linuxptp-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxptp-devel > --
_______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
