-----Original Message-----
From: Miroslav Lichvar <mlich...@redhat.com> 
Sent: Wednesday, June 1, 2022 11:28 AM

> On Mon, May 30, 2022 at 09:34:10PM +0200, Arkadiusz Kubalewski wrote:
> > Extend interface struct, allow to keep information about SyncE parent
> > device.
> > 
> > Add helper function (util.c) to acquire Do Not Use - Quality Level
> > value.
> 
> > --- a/util.c
> > +++ b/util.c
> > @@ -30,6 +30,7 @@
> >  #include "print.h"
> >  #include "sk.h"
> >  #include "util.h"
> > +#include "synce_msg.h"
> 
> This is trying to include a file that doesn't exist yet.
> 
> The patches should to be ordered and formed in such a way that the
> project can be built after each change. This is needed to not break
> bisection.
> 
> Even when adding new files that are not compiled yet, it's a good
> practice to go from the bottom to top. E.g. synce_port_ctrl.c should
> come before synce_port.c and so on.
> 

Sure, I will fix that

Thanks,
Arkadiusz

> -- 
> Miroslav Lichvar
>


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to