Hi Miroslav,
Please find the answers to the queries.
Thanks,
Devasish Dey
SyncMonk Technologies.
www.syncmonk.net
> > --- a/config.c
> > +++ b/config.c
> > @@ -240,6 +240,7 @@ struct config_item config_tab[] = {
> > GLOB_ITEM_ENU("clock_type", CLOCK_TYPE_ORDINARY, clock_type_enu),
> > GLOB_ITEM_ENU("dataset_comparison", DS_CMP_IEEE1588,
> dataset_comp_enu),
> > PORT_ITEM_INT("delayAsymmetry", 0, INT_MIN, INT_MAX),
> > + GLOB_ITEM_INT("interface_rate_tlv", 0, 0, 1),
>
> Why is it not a port-specific option? If you reject a suggestion, it's
> a good practice to explain your reasoning.
>
[Devasish]: It is for TLV support and this seems to me as a device
feature.
Anyways if the peer device or port doesn't support the TLV it gets ignored.
>
> > + if (delayAsymmetry != p->portAsymmetry) {
> > + /* Updating the nanosecond part */
>
> This comment is confusing to me.
>
[Devasish]: This was meant for the correction field updation, which
consists of
nanosecond and sub-nanosecond parts. Since the delay was in ns the comment
was
for LSH 16. Removed it now.
>
>
>
>
> _______________________________________________
> Linuxptp-devel mailing list
> Linuxptp-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
>
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
