You are correct, my bad- was a bad review based on archaic system.
Scratch that commit.

Jakub Raczynski

> 26.09.2022 10:56 Miroslav Lichvar <mlich...@redhat.com> napisał(a):
> 
>  
> On Mon, Sep 26, 2022 at 09:53:34AM +0200, j.raczynski wrote:
> > Fixed incorrect conversion of units from [us] to [ns] when polling PPS time
> > from generic master in ts2phc program.
> 
> > --- a/ts2phc_generic_pps_source.c
> > +++ b/ts2phc_generic_pps_source.c
> > @@ -42,7 +42,7 @@ static int ts2phc_generic_pps_source_getppstime(struct 
> > ts2phc_pps_source *src,
> >             return -1;
> >     }
> >     ts->tv_sec  = ntx.time.tv_sec + ntx.tai;
> > -   ts->tv_nsec = ntx.time.tv_usec;
> > +   ts->tv_nsec = ntx.time.tv_usec * 1000;
> 
> There is ADJ_NANO passed to the adjtimex call few lines above this, so
> it should be in nanoseconds, even though it says tv_usec.
> 
> Did you see a bug, or was this just a review?
> 
> -- 
> Miroslav Lichvar


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to