On Mon, Oct 17, 2022 at 06:27:12PM +0530, Devasish Dey wrote: > "The PTP connections between the T-BC-Ps allow the T-BC-Ps to support > specific monitoring types. For example, T-BC-P #D may monitor and learn the > PDV characteristics of the PTP service from T-BC-P #C. This may be used to > help the T-BC-P #D to synchronize more quickly to the T-BC-P #C backup PTP > flow should the connection to the T-GM #A fail.
Your patch set doesn't do this. > So this is not wrong at all, yes it is not in line with IEEE-1588, which we > agree on, but it is explicitly mentioned in ITU-T G.8275.2 that it does not > use the IEEE-1588 specifications in this case and so we have added the code > under Telcom conditions. If you look at the project's home page, you will see the goal clearly stated: This software is an implementation of the Precision Time Protocol (PTP) according to IEEE standard 1588 for Linux. What does that mean? It means that if you implement a feature from 1588, like alternate master, then you must follow the standard. If your particular profile changes the behavior, then add a specific flag to enable that behavior. > This feature has advantages and helps in fast > synchronization to the master in case of any network failure as the > instances are keeping track of possible best masters. You patch set does not "keep track of possible best masters". I cannot release software that claims to support a feature yet fails to do so in a way that is useful to the broad user base. Users expect to enable alternate master and have the linuxptp software do something useful. Thanks, Richard _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
