Nothing to complain about the patch, thanks for looking after the code base!
> LinuxPTP source still prefers to keep with the GNU C89 convention of > variables being at the top of the function. Newer versions of GCC have > begun defaulting to a newer C standard, which explains how these slipped in. > Note that directly enforcing "-std=c89" does not work because we rely on > some GNU extensions of C89. Has there been any discussion about this topic? If it is hard to verify the code, then these mistakes will keep on slipping in. Is there a script or ReadMe somewhere, listing the needed compiler flags to be used in order to use the "correct" C89? C89 is now > 30y old, any plans when to move to a more modern version? Linux is from time to time dropping support for old things, so although being a project that try to support as many devices as possible, it is possible to move to more modern versions, if it is announced in time and in accordance with a plan. BR, Magnus Armholt _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
