On Wed, Nov 23, 2022 at 09:32:38PM +1100, David Mirabito wrote: > In summary: > > Previously: if eth0 goes FAULTY, it may *never* recover if totally > unrelated eth1 is flapping and producing a stream of useless RTNL messages. > With this patch (or an equivalent): if eth0 goes faulty, the fault clears > and retries after 16 seconds no matter what eth1 might be doing.
I see now, thanks for the explanation. The patch looks good to me, but I'd suggest to improve the commit message with what you said here, at least mention it's unrelated netlink messages what is interfering with the recovery. I completely missed that. -- Miroslav Lichvar _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
