On Wed, 22 Mar 2023 at 05:17, Richard Cochran <richardcoch...@gmail.com> wrote: > On Mon, Mar 20, 2023 at 09:04:59PM -0700, Kishen Maloor wrote: > > Yes, we would configure CMLDS just once per physical port on a PTP node. > > Okay, so the code should check this. > > (Haven't reviewed yet, maybe you handle that already?)
We do not because that would require IPC and largely depend on the user to provide correct configuration. Let me explain. In a typical setup, you'd have one ptp4l instance per domain, each with a different domainNumber, clockIdentity and uds_address. You'd configure one of these ptp4l instances to run the CMLDS for all of the physical ports the machine has using run_cmlds=1. The cmlds_uds_address is option is how other instances know how to talk to that one instance. If your cmlds_uds_address values are wrong you can't detect a run_cmlds misconfiguration, not with UDS at least. Note: Since config.c falls back to searching [global] when no per-port option is found, you would probably set run_cmlds=1 directly under [global] for that one ptp4l session. The reason this option is per-port is that there's no requirement that all of the PTP Instances (domains) use the same subset of links on the PTP Node so you may have no single ptp4l instance that uses all of your ports and may need to split the responsibility of prviding CMLDS between more than one instance. Best regards _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
