Hi Richard, Martin, I just back from holiday. Sorry I forgot to check the errno returned by ioctl. I saw Martin has send the fix for this issue.
Thanks Hangbin On Mon, May 01, 2023 at 09:08:30PM -0700, Richard Cochran wrote: > On Mon, May 01, 2023 at 06:29:59PM +0200, Martin Pecka wrote: > > > > A driver which supports hardware time stamping must support the > > > SIOCSHWTSTAMP ioctl and update the supplied struct hwtstamp_config with > > > the actual values as described in the section on SIOCSHWTSTAMP. It > > > should also support SIOCGHWTSTAMP. > > The support for SIOCGHWTSTAMP is optional. > > > > So it seems to me wrong to test for the bonded PHC support using this ioctl, > > which is only optional. > > +1 > > > 1. Check errno not only for EINVAL, but also for EOPNOTSUPP. This would > > solve the issue for me (and Jetsons in general), but would probably leave > > some users with bonded PHCs whose drivers do not support SIOCGHWTSTAMP > > without the possibility to use the bonded PHC. > > +1 _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
