On Mon, May 08, 2023 at 05:46:30PM +0800, Tan Tee Min wrote:

> We are working towards the Avnu conformance tests for 802.1AS-2020, and
> actually Avnu do validate whether the device can properly ignore unknown
> TLVs in received PTP messages.
> 
> Without this implementation, we observe "bad message" error when the device
> receives Sync, Pdelay_Req and Pdelay_Resp event messages with unknown TLV
> appended.

This is important information.  You need to put that into your commit
log message, as it explains the reason why your change is needed.

A proper commit log message contains three elements:

1. Context
2. Problem
3. Solution

Your log message only gave the Context.
It failed to state the problem or the solution.

Thanks,
Richard


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to