On Sun, Mar 12, 2023 at 09:07:04PM -0400, Vincent Cheng wrote:
> When local clock data set is better than remote server, log message says
> remote
> server is best master.
The message means that the given clock was selected as best from among
the foreign clocks.
> The port states are correct.
>
> ex. local clock is clock class 6 and remote server on port 1 is clock class 7.
>
> ptp4l[5709.306]: selected best master clock 080027.fffe.fd0000
> ptp4l[5709.306]: port 1 (enp0s8): assuming the grand master role
I agree that the message could be confusing. Maybe we should change
it to: "best foreign clock is 080027.fffe.fd0000" ?
> @@ -2179,7 +2179,7 @@ static void handle_state_decision_event(struct clock *c)
> best = fc;
> }
>
> - if (best) {
> + if (best && c->dscmp(&best->dataset, clock_default_ds(c)) > 0) {
> best_id = best->dataset.identity;
I won't take this patch, because 'best_id' is used later on in this
function, and it isn't clear whether this change affects the logic.
Thanks,
Richard
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
