Re: [Linuxptp-devel] Is intel i350 ptp driver broken?

[Jacob Keller]

On 5/26/2023 7:36 AM, egg car wrote:
> Dear Richard,
> 
> Ah yes I have figured out that the problem is not ts2phc, it should be
> fixed in igb_extts() at igb_main.c
> 
>       if (hw->mac <https://elixir.bootlin.com/linux/v5.19.17/C/ident/mac>.type
> == e1000_82580 <https://elixir.bootlin.com/linux/v5.19.17/C/ident/e1000_82580>
> ||
>>          hw->mac 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/mac>.type == e1000_i354 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/e1000_i354> ||
>>          hw->mac 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/mac>.type == e1000_i350 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/e1000_i350>) {
>>              s64 <https://elixir.bootlin.com/linux/v5.19.17/C/ident/s64> ns 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/ns> = rd32 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/rd32>(auxstmpl);
>>
>>              ns <https://elixir.bootlin.com/linux/v5.19.17/C/ident/ns> += 
>> ((s64 <https://elixir.bootlin.com/linux/v5.19.17/C/ident/s64>)(rd32 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/rd32>(auxstmph) & 0xFF)) 
>> << 32;
>>              ts <https://elixir.bootlin.com/linux/v5.19.17/C/ident/ts> = 
>> ns_to_timespec64 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/ns_to_timespec64>(ns 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/ns>);
>>      } else {
>>              ts 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/ts>.tv_nsec 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/tv_nsec> = rd32 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/rd32>(auxstmpl);
>>              ts 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/ts>.tv_sec 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/tv_sec>  = rd32 
>> <https://elixir.bootlin.com/linux/v5.19.17/C/ident/rd32>(auxstmph);
>>      }
>>
>> here the driver does treat the AUXSTMPH resolution and valid bits in the
> right way, but forgot to convert the raw circle counter value to
> valid time stamp value.
> 
> I'll test the patch next week
> 
> Thanks for your attention
> 

Hello,

I don't work directly on this driver much these days, but if you send a
patch feel free to Cc me. I can review it and do my best to encourage
the current maintainers to merge it.

Thanks,
Jake


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel