On Wed, 14 Jun 2023 at 06:25, Richard Cochran <richardcoch...@gmail.com> wrote:
> On Tue, Jun 13, 2023 at 01:01:11PM +0200, Erez wrote: > > > Just so I am clear on the matter. > > I simply suggest taking the same test you run with linuxptp-testsuite. > > And run it in a github action. So we can all run it before we send > patches. > > In addition to the tests you run :-) > > I run the tests _before_ I push anything to github. > Developers can and should run linuxptp-testsuite on their patches > before posting to the list. > That is good advice. Yet looking at the repositories, I can not tell which tests you actually run. Or which tests you expect me to run. > > You can add it into your pre-commit git hook, for example. > This is a good option developers can use. > > Once a commit lands in github, then it is too late. > > You can use github before, if you: 1. push the patch in a forked repository. 2. Open a new branch. for the github action. You can actually mark a github action to skip the master branch, as it is too late, as you say. The benefit of the github action is that we all can run the same test. Of course I can run many tests, but I can never be sure I run the same one you did. Running different tests is great, and yet, I think that a test we all run can benefit too. A regression test that tries to verify we did not break something that is working. Erez > Thanks, > Richard >
_______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
