On Thu, Aug 31, 2023 at 01:40:13PM -0700, Trey Harrison wrote:
> So this morning I downloaded and built the latest code from github and
> found that phc2sys would occasionally segfault on startup, due to the
> following:
> 
> phc2sys.c line 1481:
>   config_set_string(cfg, "uds_address", uds_remotes[0]);
> 
> I fixed it as follows:
> 
> if (uds_remote_cnt>0)
>   config_set_string(cfg, "uds_address", uds_remotes[0]);

Good catch. The default value of the -z option is broken with -w.

The fix looks good to me, except it should have "(uds_remote_cnt > 0)"
to follow the coding style.

Will you submit it as a git-formatted patch with subject and commit
message, or would you prefer me to do it?

Thanks,

-- 
Miroslav Lichvar



_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to