Dear all, I sent a new patch review introducing a new PORT_STATS_2_NP TLV. Can you consider to review the new patch?
ciao luigi ________________________________ Da: Richard Cochran <richardcoch...@gmail.com> Inviato: lunedì 4 settembre 2023 03:45 A: Luigi Mantellini <luigi.mantell...@gmail.com> Cc: linuxptp-devel@lists.sourceforge.net <linuxptp-devel@lists.sourceforge.net> Oggetto: Re: [Linuxptp-devel] [PATCH 1/1] Add more counters to Port Stats Caution: This message was sent from an external source. Please take care when clicking links or opening attachments. When in doubt, contact your IT Department On Mon, Aug 21, 2023 at 11:24:25AM +0200, Luigi Mantellini wrote: > The PORTS_STATS_NP carries RX/TX counters for each Message Type. > The following patch fills the spare slots in order to add the following > counters: > > (MSG_TYPES EVENT 0x0...0x3) > RX_BAD_MESSAGE 0x4 > RX_BAD_PROTOCOL 0x5 > RX_FAIL_RECEIVE 0x6 > RX_MISSING_TIMESTAMP 0x7 > (MSG_TYPES GENERAL 0x8...0xD) > RX_ANNOUNCE_FOREIGN_MASTER 0xE > RX_ANNOUNCE_CURRENT_MASTER 0xF > > (MSG_TYPES EVENT 0x0...0x3) > TX_FAIL_TRANSMIT 0x6 > TX_MISSING_TIMESTAMP 0x7 > (MSG_TYPES GENERAL 0x8...0xD) > (AVAILABLE 0xE...0xF) IMO is isn't wise to re-use message type code that might one day become offical new message types. Better to simply make a new reporting structure. You can include those message counters in your new structure. Thanks, Richard _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sourceforge.net%2Flists%2Flistinfo%2Flinuxptp-devel&data=05%7C01%7Cluigi.mantellini%40sm-optics.com%7C895e416f33e94c4bae4908dbace90e07%7C213385be51b14c008384b599671fbf95%7C0%7C0%7C638293889201942656%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PZdwbmKqRJLT0WTbFWr0fbza85SJR03tWsXvvWBzA3o%3D&reserved=0<https://lists.sourceforge.net/lists/listinfo/linuxptp-devel>
_______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
