I Richard,
Thanks for your feedback.
As already said in the previous email, for PM (Annex j, the final goal)
purposes it's mandatory to capture all counters in order to be coherent. In
order to avoid overloading the existing PORT_STATS_NP message I added the
PORT_STATS_2_NP that carries also the additional information. This is the
only way that I can imagine in order to have the counters snapshot in an
atomic way. We cannot carry two GET queries in the same management message
and we cannot send two separate GET queries (ie, PORT_STATS_NP and
PORT_BAD_MESSAGES_NP) because the answers will be referred to different
time point and it's not correct.
Thanks again,
luigi
Il giorno ven 10 nov 2023 alle ore 06:40 Richard Cochran <
richardcoch...@gmail.com> ha scritto:
> On Wed, Sep 06, 2023 at 09:36:38AM +0200, Luigi Mantellini wrote:
> > The PORTS_STATS_2_NP carries all the PORTS_STATS_NP RX/TX counters
> > adding room for extra counters (up to 16 counters for RX and TX).
> > Not all counters are filled yet.
> >
> > The PORTS_STATS_2_NP TLV has the following definition:
> >
> > struct port_stats_2_np {
> > struct PortIdentity portIdentity; // As PORT_STATS_NP
> > struct PortStats stats; // As PORT_STATS_NP
> > struct PortStats extraStats; // Extra room
> > } PACKED;
> >
> > The proposed implementation adds the following counters:
> >
> > Offset Dir Description
> > 0x00 RX Bad Message
> > 0x01 RX Bad Protocol
> > 0x02 RX Fail on Receive
> > 0x03 RX Missing Timestamp
> > 0x04 RX Announce from Foreign Masters (used by 1588-2019 Annex J)
> > 0x05 RX Announce from current Master
> > 0x02 TX Fail on Transmit
> > 0x03 TX Missing Timestamp
>
> Please don't overload the existing rx/tx message counters in this way.
>
> If you really want to count "Bad Message" etc, please create a new
> data structure with fields like "bad_message" etc.
>
> Thanks,
> Richard
>
--
*Luigi 'Comio' Mantellini*
My Professional Profile <http://www.linkedin.com/in/comio>
*"UNIX is very simple, it just needs a genius to understand its
simplicity." [cit.]*
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
