Honestly, I don't know, is it necessary to dynamically switch RX filters, If the device supports EVENT RX filters, because with EVENT RX filters it can handle all PTP messages. Maybe you could suggest appropriate behaviour for utility in that case?
Yes, I agree that it can be added as a new enum to hwts_filter, but I found that ptp4l can get info about supported RX filters through ethtool, and these RX filters are specified in device driver. So, I think, ptp4l can find out for itself whether the device supports EVENT RX filters or not. Maybe that solution is better? On Tue, 14 Nov 2023 at 15:29, Miroslav Lichvar <mlich...@redhat.com> wrote: > On Mon, Nov 13, 2023 at 08:47:48PM +0300, IlorDash wrote: > > I assumed, if these filters are defined in Kernel, they might be used in > > ptp4l utility to fix this. So I added adv_rx_filter config that allows > > to send SIOCSHWTSTAMP ioctl with HWTSTAMP_FILTER_PTP_XXX_SYNC or > > HWTSTAMP_FILTER_PTP_XXX_DELAY_REQ rx filters for all transport levels. > > With this dynamic switching of the RX filter on port state changes is > there a reason to not do it by default? Or instead of adding a new > option add it as a new enum to the existing hwts_filter option? > > -- > Miroslav Lichvar > > -- Best regards, Ilya Orazov MIET Student ilordas...@gmail.com github.com/IlorDash
_______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
